Fix path-only Python project manager defaults - #1667
Open
Atomie CHEN (atomiechen) wants to merge 2 commits into
Open
Fix path-only Python project manager defaults#1667Atomie CHEN (atomiechen) wants to merge 2 commits into
Atomie CHEN (atomiechen) wants to merge 2 commits into
Conversation
Assisted-by: OpenAI Codex
Atomie CHEN (atomiechen)
force-pushed
the
fix-optional-python-project-managers
branch
from
July 27, 2026 10:55
d7702f7 to
8a98b2f
Compare
Author
|
@microsoft-github-policy-service agree |
|
🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR. |
| test('uses default managers when a pythonProjects entry only specifies path', () => { | ||
| sinon.stub(workspaceApis, 'getConfiguration').returns(createPathOnlyProjectConfig()); | ||
| sinon.stub(workspaceApis, 'getWorkspaceFolder').returns(workspaceFolder); | ||
|
|
There was a problem hiding this comment.
Info · Optional note
The fallback test covers omitted manager values but not explicitly empty strings, despite the PR claiming both cases. Consider adding empty-string assertions to preserve that behavior explicitly.
[verified]
Heejae Chang (heejaechang)
approved these changes
Aug 19, 2026
Heejae Chang (heejaechang)
left a comment
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Heejae Chang (heejaechang)
added
the
review-auto:approved
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1666.
Path-only entries are valid according to the
python-envs.pythonProjectssetting schema:{ "python-envs.pythonProjects": [ { "path": "backend" } ] }However, the manager-setting helpers called
.lengthon the omittedenvManagerandpackageManagerproperties. This caused repeatedTypeErrorfailures during post-initialization telemetry and environment lookup.Fix
PythonProjectSettings.envManagerand.packageManageroptional so the internal type matches the contributed JSON schema.Validation
--user-data-dir/--extensions-dirprofile.TypeErroror post-initialization failure.npm run compile-testsnpm run lintnpm run unittest— 1,429 passing, 6 pendingAI disclosure: Prepared with assistance from OpenAI Codex.